AnotherFoxGuy/polyvox
1
0
Fork 0
Code Issues Pull Requests Activity

Comments on const_cast.

Browse Source
This commit is contained in:
David Williams 2010-12-09 23:08:25 +00:00
parent 11fc214583
commit 2bbd401351
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
library/PolyVoxCore/include/AStarPathfinder.inl
View File

@ -69,13 +69,15 @@ namespace PolyVox
//Clear the result //Clear the result
m_params.result->clear(); m_params.result->clear();
//Iterators to start and end node.
AllNodesContainer::iterator startNode = allNodes.insert(Node(m_params.start.getX(), m_params.start.getY(), m_params.start.getZ())).first; AllNodesContainer::iterator startNode = allNodes.insert(Node(m_params.start.getX(), m_params.start.getY(), m_params.start.getZ())).first;
AllNodesContainer::iterator endNode = allNodes.insert(Node(m_params.end.getX(), m_params.end.getY(), m_params.end.getZ())).first; AllNodesContainer::iterator endNode = allNodes.insert(Node(m_params.end.getX(), m_params.end.getY(), m_params.end.getZ())).first;
/*Node::startPos = startNode->position; //Regarding the const_cast - normally you should not modify an object which is in an sdt::set.
Node::endPos = endNode->position; //The reason is that objects in a set are stored sorted in a tree so they can be accessed quickly,
Node::m_eConnectivity = m_eConnectivity;*/ //and changing the object directly can break the sorting. However, in our case we have provided a
//custom sort operator for the set which we know only uses the position to sort. Hence we can safely
//modify other properties of the object while it is in the set.
Node* tempStart = const_cast<Node*>(&(*startNode)); Node* tempStart = const_cast<Node*>(&(*startNode));
tempStart->gVal = 0; tempStart->gVal = 0;
tempStart->hVal = computeH(startNode->position, endNode->position); tempStart->hVal = computeH(startNode->position, endNode->position);
@ -170,6 +172,11 @@ namespace PolyVox
} }
else else
{ {
//Regarding the const_cast - normally you should not modify an object which is in an sdt::set.
//The reason is that objects in a set are stored sorted in a tree so they can be accessed quickly,
//and changing the object directly can break the sorting. However, in our case we have provided a
//custom sort operator for the set which we know only uses the position to sort. Hence we can safely
//modify other properties of the object while it is in the set.
Node* n = const_cast<Node*>(&(*endNode)); Node* n = const_cast<Node*>(&(*endNode));
while(n != 0) while(n != 0)
{ {
@ -228,12 +235,14 @@ namespace PolyVox
if((openIter == openNodes.end()) && (closedIter == closedNodes.end())) if((openIter == openNodes.end()) && (closedIter == closedNodes.end()))
{ {
//Regarding the const_cast - normally you should not modify an object which is in an sdt::set.
//The reason is that objects in a set are stored sorted in a tree so they can be accessed quickly,
//and changing the object directly can break the sorting. However, in our case we have provided a
//custom sort operator for the set which we know only uses the position to sort. Hence we can safely
//modify other properties of the object while it is in the set.
Node* temp = const_cast<Node*>(&(*neighbour)); Node* temp = const_cast<Node*>(&(*neighbour));
temp->gVal = cost; temp->gVal = cost;
openNodes.insert(neighbour); openNodes.insert(neighbour);
temp->parent = const_cast<Node*>(&(*current)); temp->parent = const_cast<Node*>(&(*current));
} }
} }