4 Commits
v0.2 ... v0.3

Author SHA1 Message Date
fc0e761394 build: Bump version to 0.3 2016-06-22 12:16:50 +05:30
df47d74bc3 doc: Update NEWS for release 2016-06-22 12:12:10 +05:30
066cf53da7 build: Make sure files with SSE2 code are compiled with -msse2
Signed-off-by: Arun Raghavan <arun@arunraghavan.net>
2016-06-21 16:46:48 +05:30
d58164e4d8 build: enforce linking with --no-undefined, add explicit -lpthread
In investigating x86/sse2 issues in recent webrtc-audio-processing-0.2
release, I found that it was possible for libwebrtc_audio_processing to
contain undefined symbols.

Attached is a patch that addresses this:
* adds -Wl,--no-undefined to libwebrtc_audio_processing_la_LDFLAGS
* adds explicit -lpthread linkage (else, there are undefined references
  to pthread-related symbols)

Signed-off-by: Arun Raghavan <arun@arunraghavan.net>
2016-06-01 10:09:45 +05:30
4 changed files with 27 additions and 5 deletions

6
NEWS
View File

@ -1,3 +1,9 @@
Release 0.3
-----------
Minor build fixes.
Release 0.2 Release 0.2
----------- -----------

View File

@ -1,4 +1,4 @@
AC_INIT([webrtc-audio-processing], [0.2]) AC_INIT([webrtc-audio-processing], [0.3])
AM_INIT_AUTOMAKE([dist-xz subdir-objects tar-ustar]) AM_INIT_AUTOMAKE([dist-xz subdir-objects tar-ustar])
AC_SUBST(LIBWEBRTC_AUDIO_PROCESSING_VERSION_INFO, [1:0:0]) AC_SUBST(LIBWEBRTC_AUDIO_PROCESSING_VERSION_INFO, [1:0:0])

View File

@ -93,10 +93,17 @@ libcommon_audio_la_SOURCES = resampler/include/push_resampler.h \
window_generator.cc window_generator.cc
if HAVE_X86 if HAVE_X86
libcommon_audio_la_SOURCES += \ noinst_LTLIBRARIES += libcommon_audio_sse2.la
libcommon_audio_sse2_la_SOURCES = \
resampler/sinc_resampler_sse.cc \ resampler/sinc_resampler_sse.cc \
fir_filter_sse.cc \ fir_filter_sse.cc \
fir_filter_sse.h fir_filter_sse.h
libcommon_audio_sse2_la_CFLAGS = $(AM_CFLAGS) $(COMMON_CFLAGS) -msse2
libcommon_audio_sse2_la_CXXFLAGS = $(AM_CXXFLAGS) $(COMMON_CXXFLAGS) -msse2
libcommon_audio_sse2_la_LDFLAGS = $(AM_LDFLAGS)
libcommon_audio_la_LIBADD = libcommon_audio_sse2.la
endif endif
if HAVE_ARM if HAVE_ARM

View File

@ -147,9 +147,14 @@ libwebrtc_audio_processing_la_SOURCES += \
endif endif
if HAVE_X86 if HAVE_X86
libwebrtc_audio_processing_la_SOURCES += \ noinst_LTLIBRARIES = libwebrtc_audio_processing_privatearch.la
LIBWEBRTC_PRIVATEARCH=libwebrtc_audio_processing_privatearch.la
libwebrtc_audio_processing_privatearch_la_SOURCES = \
aec/aec_core_sse2.c \ aec/aec_core_sse2.c \
aec/aec_rdft_sse2.c aec/aec_rdft_sse2.c
libwebrtc_audio_processing_privatearch_la_CFLAGS = $(AM_CFLAGS) $(COMMON_CFLAGS) -msse2
libwebrtc_audio_processing_privatearch_la_CXXFLAGS = $(AM_CXXFLAGS) $(COMMON_CXXFLAGS) -msse2
libwebrtc_audio_processing_privatearch_la_LDFLAGS = $(AM_LDFLAGS)
endif endif
if HAVE_NEON if HAVE_NEON
@ -166,8 +171,12 @@ libwebrtc_audio_processing_la_LIBADD = $(top_builddir)/webrtc/libwebrtc.la \
$(top_builddir)/webrtc/base/libbase.la \ $(top_builddir)/webrtc/base/libbase.la \
$(top_builddir)/webrtc/system_wrappers/libsystem_wrappers.la \ $(top_builddir)/webrtc/system_wrappers/libsystem_wrappers.la \
$(top_builddir)/webrtc/common_audio/libcommon_audio.la \ $(top_builddir)/webrtc/common_audio/libcommon_audio.la \
$(top_builddir)/webrtc/modules/audio_coding/libaudio_coding.la $(top_builddir)/webrtc/modules/audio_coding/libaudio_coding.la \
libwebrtc_audio_processing_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(LIBWEBRTC_AUDIO_PROCESSING_VERSION_INFO) $(LIBWEBRTC_PRIVATEARCH) \
-lpthread
libwebrtc_audio_processing_la_LDFLAGS = $(AM_LDFLAGS) \
-Wl,--no-undefined \
-version-info $(LIBWEBRTC_AUDIO_PROCESSING_VERSION_INFO)
# FIXME: The MIPS optimisations need to be hooked up once we have the # FIXME: The MIPS optimisations need to be hooked up once we have the
# autotools conditionals in place # autotools conditionals in place